Commit graph

20 commits

Author SHA1 Message Date
francisco souza
5a59f896b9
gobin: make sure GOPATH gets trimmed before use in path.join
On Windows, `go env GOPATH` keeps the end-line character, making it
unusable (see sample build failure:
https://github.com/fsouza/vod-module-sprite/runs/478762225?check_suite_focus=true#step:5:62).
2020-03-01 23:59:03 -05:00
francisco souza
4241f446d8
gobin: use execFile instead of exec to query GOPATH
Should fix the behavior on Windows.
2020-03-01 22:07:49 -05:00
francisco souza
0dbc2e7f12
Fix tests for gobin on Windows 2020-03-01 21:34:51 -05:00
francisco souza
25c870be4d
Add $GOBIN
- Set $GOBIN to $(go env GOPATH)/bin
- Add $GOBIN to the PATH

Should make the setup of tools like golangci-lint or golint work with a
simple `go get`.

Using $GOBIN instead of $GOPATH/bin because the goal is to have GOPATH
not being directly referenced. Also, in the future, GOBIN will have a
default value too, so we would not need to manually set it, just add it
to the path (see discussion in golang/go#23439).

Closes #14.
2020-03-01 21:18:28 -05:00
Bryan MacFarlane
768458bd0b pre-release version and test 2020-02-10 19:18:01 -05:00
Bryan MacFarlane
43880314e9 CR feedback 2020-02-10 15:21:04 -05:00
Bryan MacFarlane
7d57e56d4d update tests 2020-02-09 19:05:20 -05:00
Bryan MacFarlane
6cb99a33d7 another test 2020-02-09 18:48:40 -05:00
Bryan MacFarlane
241a335117 mock os instead of system 2020-02-09 18:22:24 -05:00
Bryan MacFarlane
79b62adb05 another test and bugs 2020-02-09 18:09:15 -05:00
Bryan MacFarlane
7af81a4a65 bit of cleanup 2020-02-09 14:39:34 -05:00
Bryan MacFarlane
f4b0281c15 mocked tests work with no internet 2020-02-09 09:25:20 -05:00
Bryan MacFarlane
dc575ee3b3 format 2020-02-09 00:29:21 -05:00
Bryan MacFarlane
4282769cc0 starting v2 and proxy support 2020-02-09 00:21:39 -05:00
Alif Rachmawadi
bc6edb526d
update test assertion 2019-09-05 13:27:28 +07:00
Alif Rachmawadi
21620fff65
use golang-dl release data 2019-09-05 13:09:55 +07:00
Alif Rachmawadi
632d18fc92 Handle .x version syntax with latest release (#13)
* get latest release for .x syntax version

* added nock as dev dependency

* added test for .x syntax

* updated readme

* updated http client name

* use rest client for getting available versions

* more .x handling

* move nock to setup and teardown
2019-08-19 08:28:37 -04:00
Stephen Franceschelli
136ed85710 Fix build. (#7)
* Fix.

* Husky commit correct node modules
2019-07-30 13:37:35 -04:00
Danny McCormick
f34fd68566 Add installer 2019-06-20 13:28:39 -04:00
Danny McCormick
cd176c696b Add setup-go 2019-06-19 09:44:17 -04:00