actions/setup-go
1
0
Fork 0
mirror of https://github.com/actions/setup-go.git synced 2025-07-01 05:33:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

gobin: make sure GOPATH gets trimmed before use in path.join

Browse source 
On Windows, `go env GOPATH` keeps the end-line character, making it
unusable (see sample build failure:
478762225 (step):5:62).
This commit is contained in:
francisco souza 2020-03-01 23:59:03 -05:00
parent 4241f446d8
commit 5a59f896b9
No known key found for this signature in database
GPG key ID: 3F6AA3B701F20B3E
3 changed files with 10 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

8
__tests__/gobin.test.ts
View file

@ -20,4 +20,12 @@ describe('gobin', () => {
const gobinPath = await gobin.getGOBIN('...');
expect(gobinPath).toBe(path.join(gopath, 'bin'));
});
it('should trim ${GOPATH} before using it', async () => {
let trimmed = gopath;
gopath = `${gopath}\r\n`;
const gobinPath = await gobin.getGOBIN('...');
expect(gobinPath).toBe(path.join(trimmed, 'bin'));
});
});