core_v8-no-enum-constexrp-conversion: fixes v8 build on ubuntu 22.04
Some checks failed
/ release-build (push) Successful in 1h13m52s
/ release-deploy (push) Failing after 36s
/ test-build (pull_request) Failing after 21m1s

This commit is contained in:
Antoine Martin 2024-08-24 17:26:05 -04:00
parent 26497e918b
commit 748136ba54
Signed by: ayakael
GPG key ID: D62A472A4AA7D541

View file

@ -0,0 +1,34 @@
diff --git a/core/Common/3dParty/v8/tools/no-enum-constexrp-conversion.patch b/core/Common/3dParty/v8/tools/no-enum-constexrp-conversion.patch
new file mode 100644
index 0000000000..5a1a8067a6
--- /dev/null
+++ b/core/Common/3dParty/v8/tools/no-enum-constexrp-conversion.patch
@@ -0,0 +1,14 @@
+diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
+index 5ea2f213..29fa7742 100644
+--- a/build/config/compiler/BUILD.gn
++++ b/build/config/compiler/BUILD.gn
+@@ -1548,6 +1548,9 @@ config("default_warnings") {
+ # TODO(https://crbug.com/989932): Evaluate and possibly enable.
+ "-Wno-implicit-int-float-conversion",
+
++ "-Wno-enum-constexpr-conversion",
++
++
+ # TODO(https://crbug.com/999886): Clean up, enable.
+ "-Wno-final-dtor-non-final-class",
+
diff --git a/build_tools/scripts/core_common/modules/v8_89.py b/core/build_tools/core_common/modules/v8_89.py
index 9643263..35ee1fe 100644
--- a/build_tools/scripts/core_common/modules/v8_89.py
+++ b/build_tools/scripts/core_common/modules/v8_89.py
@@ -150,6 +150,8 @@ def make():
"use_custom_libcxx=false",
"treat_warnings_as_errors=false"]
+ base.cmd("patch", ["-p1", "-i", "../../v8/tools/no-enum-constexrp-conversion.patch"])
+
if config.check_option("platform", "linux_64"):
base.cmd2("gn", ["gen", "out.gn/linux_64", make_args(gn_args, "linux")])
base.cmd("ninja", ["-C", "out.gn/linux_64"])