From 098f0d7c5c28a1beef812273c704945b55395183 Mon Sep 17 00:00:00 2001 From: Dmitry Shibanov Date: Fri, 4 Feb 2022 12:20:33 +0300 Subject: [PATCH] add comments --- dist/setup/index.js | 3 +++ src/cache-distributions/pip-cache.ts | 3 +++ 2 files changed, 6 insertions(+) diff --git a/dist/setup/index.js b/dist/setup/index.js index 24085164..a742d588 100644 --- a/dist/setup/index.js +++ b/dist/setup/index.js @@ -34480,6 +34480,9 @@ class PipCache extends cache_distributor_1.default { let stdout = ''; let stderr = ''; // Add temporary fix for Windows + // On windows it is necessary to execute through an exec + // because the getExecOutput gives a non zero code or writes to stderr for pip 22.0.2, + // or spawn must be started with the shell option enabled for getExecOutput // Related issue: https://github.com/actions/setup-python/issues/328 if (utils_1.IS_WINDOWS) { const execPromisify = util_1.default.promisify(child_process.exec); diff --git a/src/cache-distributions/pip-cache.ts b/src/cache-distributions/pip-cache.ts index 78ab1ebe..17055ea5 100644 --- a/src/cache-distributions/pip-cache.ts +++ b/src/cache-distributions/pip-cache.ts @@ -23,6 +23,9 @@ class PipCache extends CacheDistributor { let stderr = ''; // Add temporary fix for Windows + // On windows it is necessary to execute through an exec + // because the getExecOutput gives a non zero code or writes to stderr for pip 22.0.2, + // or spawn must be started with the shell option enabled for getExecOutput // Related issue: https://github.com/actions/setup-python/issues/328 if (IS_WINDOWS) { const execPromisify = utils.promisify(child_process.exec);