actions/setup-node
1
0
Fork 0
mirror of https://github.com/actions/setup-node.git synced 2025-07-05 00:53:47 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

work on resolving comments

Browse source
This commit is contained in:
Dmitry Shibanov 2022-11-08 20:38:57 +01:00
parent 65270bbd55
commit 882cfbaf78
5 changed files with 54 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

11
src/installer.ts
View file

@ -370,7 +370,7 @@ function evaluateNightlyVersions(
versionSpec: string
): string {
let version = '';
let range: string | null | undefined;
let range: string | undefined;
const [raw, prerelease] = versionSpec.split('-');
const isValidVersion = semver.valid(raw);
const rawVersion = isValidVersion ? raw : semver.coerce(raw);
@ -383,7 +383,7 @@ function evaluateNightlyVersions(
}
if (range) {
versions.sort((a, b) => +semver.lt(a, b) - 0.5);
versions.sort(semver.rcompare);
for (const currentVersion of versions) {
const satisfied: boolean =
semver.satisfies(
@ -416,12 +416,7 @@ function evaluateVersions(versions: string[], versionSpec: string): string {
return evaluateNightlyVersions(versions, versionSpec);
}
versions = versions.sort((a, b) => {
if (semver.gt(a, b)) {
return 1;
}
return -1;
});
versions = versions.sort(semver.rcompare);
for (let i = versions.length - 1; i >= 0; i--) {
const potential: string = versions[i];
const satisfied: boolean = semver.satisfies(potential, versionSpec);