fix: cache key should include node version

This commit is contained in:
Steven 2022-09-30 15:11:50 -04:00
parent 969bd26639
commit 2792b3f52b
3 changed files with 12 additions and 8 deletions

View file

@ -108,7 +108,7 @@ describe('cache-restore', () => {
it.each([['npm7'], ['npm6'], ['pnpm6'], ['yarn1'], ['yarn2'], ['random']])(
'Throw an error because %s is not supported',
async packageManager => {
await expect(restoreCache(packageManager)).rejects.toThrowError(
await expect(restoreCache('v16.17.1', packageManager)).rejects.toThrowError(
`Caching for '${packageManager}' is not supported`
);
}
@ -132,10 +132,10 @@ describe('cache-restore', () => {
}
});
await restoreCache(packageManager);
await restoreCache('v16.17.1', packageManager);
expect(hashFilesSpy).toHaveBeenCalled();
expect(infoSpy).toHaveBeenCalledWith(
`Cache restored from key: node-cache-${platform}-${packageManager}-${fileHash}`
`Cache restored from key: node-cache-v16-${platform}-${packageManager}-${fileHash}`
);
expect(infoSpy).not.toHaveBeenCalledWith(
`${packageManager} cache is not found`
@ -163,7 +163,7 @@ describe('cache-restore', () => {
});
restoreCacheSpy.mockImplementationOnce(() => undefined);
await restoreCache(packageManager);
await restoreCache('v16.17.1', packageManager);
expect(hashFilesSpy).toHaveBeenCalled();
expect(infoSpy).toHaveBeenCalledWith(
`${packageManager} cache is not found`