actions/setup-go
1
0
Fork 0
mirror of https://github.com/actions/setup-go.git synced 2025-04-23 17:40:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

resolving comments

Browse source
This commit is contained in:
Dmitry Shibanov 2022-02-08 16:27:34 +03:00
parent 1b3105fea3
commit df1bbd3ffb
4 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
README.md
View file

@ -20,7 +20,7 @@ The V2 offers:
- Check latest version - Check latest version
- Bug Fixes (including issues around version matching and semver) - Bug Fixes (including issues around version matching and semver)
The action will first check the local cache for a version match. If a version is not found locally, it will pull it from the `main` branch of the [go-versions](https://github.com/actions/go-versions/blob/main/versions-manifest.json) repository and on miss or failure, will fall back to the previous behavior of downloading directly from [go dist](https://storage.googleapis.com/golang). To change the default behaviour please use the [check-latest input](#check-latest-version). The action will first check the local cache for a version match. If a version is not found locally, it will pull it from the `main` branch of the [go-versions](https://github.com/actions/go-versions/blob/main/versions-manifest.json) repository. On miss or failure, it will fall back to downloading directly from [go dist](https://storage.googleapis.com/golang). To change the default behavior, please use the [check-latest input](#check-latest-version).
Matching by [semver spec](https://github.com/npm/node-semver): Matching by [semver spec](https://github.com/npm/node-semver):
```yaml ```yaml

2
__tests__/setup-go.test.ts
View file

@ -724,7 +724,7 @@ describe('setup-go', () => {
'Attempt to resolve the latest version from manifest...' 'Attempt to resolve the latest version from manifest...'
); );
expect(logSpy).toHaveBeenCalledWith( expect(logSpy).toHaveBeenCalledWith(
'Unable to resolve version from manifest...' 'Unable to resolve a version from the manifest...'
); );
expect(logSpy).toHaveBeenCalledWith( expect(logSpy).toHaveBeenCalledWith(
`Failed to resolve version ${versionSpec} from manifest` `Failed to resolve version ${versionSpec} from manifest`

2
dist/index.js vendored
View file

@ -5966,7 +5966,7 @@ function resolveVersionFromManifest(versionSpec, stable, auth) {
return info === null || info === void 0 ? void 0 : info.resolvedVersion; return info === null || info === void 0 ? void 0 : info.resolvedVersion;
} }
catch (err) { catch (err) {
core.info('Unable to resolve version from manifest...'); core.info('Unable to resolve a version from the manifest...');
core.debug(err.message); core.debug(err.message);
} }
}); });

2
src/installer.ts
View file

@ -122,7 +122,7 @@ async function resolveVersionFromManifest(
const info = await getInfoFromManifest(versionSpec, stable, auth); const info = await getInfoFromManifest(versionSpec, stable, auth);
return info?.resolvedVersion; return info?.resolvedVersion;
} catch (err) { } catch (err) {
core.info('Unable to resolve version from manifest...'); core.info('Unable to resolve a version from the manifest...');
core.debug(err.message); core.debug(err.message);
} }
} }