actions/git-backporting
1
0
Fork 0
mirror of https://github.com/kiegroup/git-backporting.git synced 2025-05-10 18:53:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor: changed method name and removed useless data

Browse source
This commit is contained in:
Andrea Lamparelli 2023-06-22 17:57:49 +02:00
parent 99fbcc39cc
commit a30b6d6290
8 changed files with 19 additions and 34 deletions
Download patch file Download diff file Expand all files Collapse all files

10
dist/cli/index.js vendored
View file

@ -181,8 +181,8 @@ class PullRequestConfigsParser extends configs_parser_1.default {
targetRepo: originalPullRequest.targetRepo,
sourceRepo: originalPullRequest.targetRepo,
branchName: args.bpBranchName,
nCommits: 0,
commits: [] // TODO needed?
// nCommits: 0, // not needed, but required by the
// commits: [] // not needed
};
}
}
@ -342,8 +342,7 @@ class GitServiceFactory {
* @param type git management service type
* @param auth authentication, like github token
*/
// TODO rename to getOrCreate
static init(type, auth) {
static getOrCreate(type, auth) {
if (GitServiceFactory.instance) {
GitServiceFactory.logger.warn("Git service already initialized!");
return;
@ -664,7 +663,6 @@ class Runner {
* Entry point invoked by the command line or gha
*/
async run() {
this.logger.info("Starting process.");
try {
await this.execute();
this.logger.info("Process succeeded!");
@ -686,7 +684,7 @@ class Runner {
this.logger.warn("Dry run enabled!");
}
// 2. init git service
git_service_factory_1.default.init(this.inferRemoteGitService(args.pullRequest), args.auth);
git_service_factory_1.default.getOrCreate(this.inferRemoteGitService(args.pullRequest), args.auth);
const gitApi = git_service_factory_1.default.getService();
// 3. parse configs
const configs = await new pr_configs_parser_1.default().parseAndValidate(args);